-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Radio-Button, Checkbox and Switch to web standards #1485
Align Radio-Button, Checkbox and Switch to web standards #1485
Conversation
42abf6d
to
ce93639
Compare
|
--STORYBOOK-PREVIEW--
|
ce93639
to
c532f13
Compare
…252dbed7b76a9deb06e705f2f.0
…ef0978634f92643181023cd37.0
--EXAMPLE-APPS-PREVIEW--
|
…d0251e1d4e859d8ef3c8aceaf.0
…f1b1abe9496bd767a83758ec4.0
|
Added value prop to checkbox, radio-button and switch
…8c16c62d36613cf512c31633b.0
…533e97b8fba5387491d525bce.0
f23d96f
to
b6d348b
Compare
b6d348b
to
998bcfe
Compare
The checkbox doesnt have the "disabled" arg in the story anymore. Not sure why this got removed, but the checkbox should be "disable-able" |
@pfafffabian-ifx you renamed value to checked, as I could see. Fine with me, if this is in accordance with the web standard. But yes, @tishoyanchev is right, value is still used in the code as well. What do you mean by the select options not being submitted? |
I told Fabian to remove it from the snippet to avoid confusion because when the disabled attribute is present, even if set to true, the value attribute doesn't work, and no value is submitted. This might confuse users, so I told him to just remove it from the snippet. |
When you put the multi-select component inside a , and select multiple options, and then submit it, the options were not getting submitted, but his is already resolved. |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Related Issue
Closes #1479
Fixes #1476 for the Radio Button
📦 Published PR as canary version:
26.0.0--canary.1485.8162da32f9fc366646a6da72bbed42526db2b8ee.0
✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@26.0.0--canary.1485.8162da32f9fc366646a6da72bbed42526db2b8ee.0 # or yarn add @infineon/infineon-design-system-stencil@26.0.0--canary.1485.8162da32f9fc366646a6da72bbed42526db2b8ee.0