Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1566 storybook consistency and UI enhancement #1640

Open
wants to merge 147 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
147 commits
Select commit Hold shift + click to select a range
c510004
Enhanced UI in Notification, Pagination, Switch and Spinner component…
agata-kim Nov 14, 2024
57f7e2d
Enhance UI controls and descriptions in Checkbox stories
evangeliaPanteliadou Nov 14, 2024
eb638fc
Enhance UI controls and descriptions in Icon Button stories, and fix …
evangeliaPanteliadou Nov 14, 2024
757078d
Enhance UI controls and descriptions in Link stories
evangeliaPanteliadou Nov 14, 2024
f0e9129
Enhance UI controls and descriptions in Progress Bar stories
evangeliaPanteliadou Nov 15, 2024
035d955
Enhance UI controls and descriptions in Status stories
evangeliaPanteliadou Nov 15, 2024
af9da87
Enhance UI controls and descriptions in Date Picker stories
evangeliaPanteliadou Nov 15, 2024
158345d
Enhance UI controls and descriptions in Button stories
evangeliaPanteliadou Nov 15, 2024
9ee45f1
Enhance UI controls and descriptions in Number Indicator stories
evangeliaPanteliadou Nov 18, 2024
0b5865b
Enhance UI controls and descriptions in Radio Button stories
evangeliaPanteliadou Nov 18, 2024
a559efa
Enhance UI controls and descriptions in Stepper stories
evangeliaPanteliadou Nov 18, 2024
594ed30
Enhance UI controls and descriptions in Single Select stories
evangeliaPanteliadou Nov 18, 2024
b1a6332
Updated stories for Accordion, Card, Badge, and Spinner.
agata-kim Nov 18, 2024
81bf3a1
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Nov 18, 2024
6c651f8
Cleanup in Radio-Button and Card. Enhanced UI in Content Switcher
agata-kim Nov 19, 2024
b00b172
Enhanced UI in Footer and Icon
agata-kim Nov 19, 2024
8118ef6
Enhanced UI in Tag
agata-kim Nov 19, 2024
e491560
Enhanced UI in Content-Switcher
agata-kim Nov 19, 2024
ee626b8
Enhanced UI in Slider
agata-kim Nov 19, 2024
6b4114a
Enhanced UI in Tabs
agata-kim Nov 20, 2024
01d904c
Enhance UI controls and descriptions in Search Field stories
evangeliaPanteliadou Nov 20, 2024
867999f
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Nov 26, 2024
ab502d3
Enhanced UI in Modal
agata-kim Nov 26, 2024
98f60b6
Enhanced UI in Search Bar
agata-kim Nov 26, 2024
77ea888
Enhanced UI in Multiselect
agata-kim Nov 26, 2024
33473ea
Enhanced UI in Navbar
agata-kim Nov 27, 2024
f1fa41e
Enhance UI controls and descriptions in Tooltip stories
evangeliaPanteliadou Nov 27, 2024
ce72982
Enhance UI controls and descriptions in Alert stories
evangeliaPanteliadou Nov 27, 2024
77b547c
First part of enhancement in UI controls and descriptions of Dropdown…
evangeliaPanteliadou Nov 27, 2024
8d70899
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Nov 28, 2024
17bf633
Second part of enhancement in UI controls and descriptions of Dropdow…
evangeliaPanteliadou Nov 29, 2024
d0cdea6
Enhance UI controls and descriptions in Sidebar stories, change hasIc…
evangeliaPanteliadou Nov 29, 2024
6caa592
Enhance UI controls and descriptions in Text Field stories
evangeliaPanteliadou Nov 29, 2024
aeb17e6
Add "isOpen" name for the prop in Navbar
agata-kim Dec 3, 2024
072f4fc
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 3, 2024
10b6c25
Put label in story controls, remove showIcon, and other small correct…
evangeliaPanteliadou Dec 4, 2024
e792375
Enhanced UI in Breadcrumb
agata-kim Dec 4, 2024
60a4fb5
Cleanup in Accordion, Badge,Card, Icon, Modal
agata-kim Dec 4, 2024
a3883b9
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 4, 2024
03fab91
Enhanced UI in Table (basic)
agata-kim Dec 5, 2024
a7ab0a2
Cleanup. Add periods to the end of descriptions for consistency.
agata-kim Dec 5, 2024
936a050
Revert changes in maxlength prop
evangeliaPanteliadou Dec 6, 2024
b070fac
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
evangeliaPanteliadou Dec 6, 2024
3d9f2c9
Uppercase in story controls
evangeliaPanteliadou Dec 6, 2024
a725480
Description missing in Alert stories
evangeliaPanteliadou Dec 6, 2024
07edc5c
Add framework integration for events in Sidebar stories
evangeliaPanteliadou Dec 6, 2024
030d5b5
Enhanced UI in Table (advanced)
agata-kim Dec 10, 2024
9805839
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 10, 2024
854b192
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 10, 2024
a692017
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 10, 2024
13f34e2
Replaced hardcoded 'type' in the code snippet. Small change.
agata-kim Dec 10, 2024
137d16d
Cleanup in Navbar, Notification, SearchBar
agata-kim Dec 10, 2024
532200c
Merge branch 'master' into 1566-storybook-consistency-and-ui-enhancement
evangeliaPanteliadou Dec 10, 2024
67e5429
Clean up in Date Picker story
evangeliaPanteliadou Dec 10, 2024
5060f88
Merge 67e542965b327fae2edfc29b5ca4db242743e8cb into be1ffef58f2cb94c2…
evangeliaPanteliadou Dec 10, 2024
b7bf37d
Update Stencil library version to 30.1.1--canary.1640.e4770f238d16196…
invalid-email-address Dec 10, 2024
3771972
Adjusted description in Checkbox.
agata-kim Dec 18, 2024
3df213d
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 18, 2024
06807d9
Merge branch 'master' into 1566-storybook-consistency-and-ui-enhancement
agata-kim Dec 18, 2024
471b9cf
Merge branch 'master' into 1566-storybook-consistency-and-ui-enhancement
agata-kim Dec 18, 2024
730d762
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 18, 2024
dd03fc6
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 18, 2024
86f36f0
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 18, 2024
c7206c4
Manually add the changes in Table (advanced)
agata-kim Dec 18, 2024
3c21df1
Add selected prop to the Content Switcher.
agata-kim Dec 18, 2024
1f2d8b3
Clean install to pass the tests
agata-kim Dec 18, 2024
838e08b
Clean install again to pass the tests
agata-kim Dec 18, 2024
55f6082
Merge 838e08bd414982d9265ca494639fafb45595fdb3 into 2e1d79e683173691d…
evangeliaPanteliadou Dec 18, 2024
033c1db
Update Stencil library version to 30.9.2--canary.1640.55f6082d40b32de…
invalid-email-address Dec 18, 2024
77e7bda
Adjust e2e test of Multiselect.
agata-kim Dec 18, 2024
bf3e301
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 18, 2024
8926aa0
Merge bf3e301df3df0c8b12759d69e2cf949c4cdf1347 into 2e1d79e683173691d…
evangeliaPanteliadou Dec 18, 2024
5b3b9c1
Update Stencil library version to 30.9.2--canary.1640.8926aa040c1241b…
invalid-email-address Dec 18, 2024
25e422e
Renamed events in Accordion.
agata-kim Dec 19, 2024
4c03172
adjusted description in Label prop for consistency.
agata-kim Dec 19, 2024
52af796
Adjusted AriaLabel prop, removed isHovered prop in Card.
agata-kim Dec 19, 2024
cb3979f
Adjusted description for ifxDropdownMenuItem in Breadcrumb.
agata-kim Dec 19, 2024
494cc5d
Renamed ifxChipChangeevent to ifxChange in Chip.
agata-kim Dec 19, 2024
d12f71e
Add AriaLabel prop, adjusted descriptions in Chip.
agata-kim Dec 19, 2024
400682b
Add 'AriaLabel' and 'required' props in Date Picker.
agata-kim Dec 19, 2024
e10f511
Changed the naming of url prop to href in Breadcrumb.
agata-kim Dec 19, 2024
387b083
Added templates for Separator, Header and SearchField. Deleted them f…
agata-kim Dec 19, 2024
507e3ca
Adjusted description of the ifxDropdownMenuItem in Breadcrumb and Dro…
agata-kim Dec 19, 2024
5a5c90f
Cleanup in Navbar
agata-kim Dec 19, 2024
e9ba729
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Dec 19, 2024
c975b90
Merge e9ba729cf1c963a64be6fd90c2cd4f251c63d34c into 2e1d79e683173691d…
evangeliaPanteliadou Dec 19, 2024
6ba2467
Update Stencil library version to 30.9.2--canary.1640.c975b901d468735…
invalid-email-address Dec 19, 2024
d61b570
Delete value prop, add missing props of sidebar-item in Sidebar.
agata-kim Jan 2, 2025
70fa3ea
Merge d61b57000892deb5d568473e3779023549c92db5 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
8d09fec
Update Stencil library version to 30.9.2--canary.1640.70fa3eaef8e23b3…
invalid-email-address Jan 2, 2025
f3cafb8
Change "content" prop to "label" prop in Notification. Add missing ty…
agata-kim Jan 2, 2025
53d60ca
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
e256ac3
Merge 53d60cac4b37fee57eca69e67bd45d168144ecd7 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
95676c3
Update Stencil library version to 30.9.2--canary.1640.e256ac3279c7800…
invalid-email-address Jan 2, 2025
759c3dc
Delete ifxNextPage, ifxPrevPage in Pagination.
agata-kim Jan 2, 2025
72a3c17
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
bce99f4
Merge 72a3c17d03a8bb5de743ff2fca6e6368bc1a7053 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
4bbb772
Update Stencil library version to 30.9.2--canary.1640.15cdfe60ad50aa2…
invalid-email-address Jan 2, 2025
2a3793f
Add missing value prop in Search-field.
agata-kim Jan 2, 2025
8ac724b
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
d5be31b
Merge 8ac724bb48f2c1bdb24d872ec0070eb2b5656c86 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
48a8ebd
Update Stencil library version to 30.9.2--canary.1640.d5be31b23266dc2…
invalid-email-address Jan 2, 2025
2d9a8a3
Adjust ifxChange in Segmented Control
agata-kim Jan 2, 2025
c874b0b
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
6c1ebb2
Adjust Label prop in Status
agata-kim Jan 2, 2025
9290e8b
Merge 6c1ebb2646959f9214a7f5b4ae5e8e37e8d751b3 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
10eae3f
Update Stencil library version to 30.9.2--canary.1640.9290e8b37d6b9b1…
invalid-email-address Jan 2, 2025
df3ed7f
Changed behavior of error prop in Stepper story.
agata-kim Jan 2, 2025
44e69f3
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
6c2a9d1
Merge 44e69f3cfb83bd8868432d3552cfb14f1afb8af9 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
3f24700
Update Stencil library version to 30.9.2--canary.1640.6c2a9d121c5f181…
invalid-email-address Jan 2, 2025
ce9b405
Adjusted fullWidth prop in Tabs.
agata-kim Jan 2, 2025
2961038
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
f76a997
Merge 2961038f8cbd3b75b5f9ffa05ca43d064ba4277b into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
8c75e03
Update Stencil library version to 30.9.2--canary.1640.f76a9971a802bdf…
invalid-email-address Jan 2, 2025
7763410
Rename ifxTabChange to ifxChange in Tabs.
agata-kim Jan 2, 2025
d635e82
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
6b0a47c
Add missing value prop to the Text Field.
agata-kim Jan 2, 2025
c50aad9
Adjusted ifxInput description in Text Area
agata-kim Jan 2, 2025
59b07f0
Merge c50aad934f278c8d22e6966413a633c22ae3b526 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
156b8ef
Update Stencil library version to 30.9.2--canary.1640.59b07f0feaa4626…
invalid-email-address Jan 2, 2025
0b0b4a1
Adjusted props in Table (advanced).
agata-kim Jan 2, 2025
29350ef
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
abb5fbd
Merge 29350eff8926c72b5184c901f8f2d82cf9c2c778 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
f9ecd66
Update Stencil library version to 30.9.2--canary.1640.abb5fbdf690614c…
invalid-email-address Jan 2, 2025
7b073d5
Adjusted Table (basic) story.
agata-kim Jan 2, 2025
7cc3664
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 2, 2025
81e4108
Merge 7cc366489b023d77fbb57316478b73fd3c4fed26 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 2, 2025
f7d542c
Update Stencil library version to 30.9.2--canary.1640.81e4108552e63a9…
invalid-email-address Jan 2, 2025
d01345b
Add missing control for "complete" prop.
agata-kim Jan 7, 2025
10bd383
Fixed: ifxOpen and ifxClose emitted twice on one action.
agata-kim Jan 7, 2025
818b73e
Change url prop to href in Breadcrumb.
agata-kim Jan 7, 2025
c392817
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 7, 2025
7e6e3cf
Merge c39281764581540861a11298b864cb55936ec8e4 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 7, 2025
8715ae0
Update Stencil library version to 30.9.2--canary.1640.7e6e3cfaf16dd16…
invalid-email-address Jan 7, 2025
4de74e6
empty commit
tishoyanchev Jan 7, 2025
8c7b856
Merge 4de74e6f5657dee4d9ae11f2ae0b974a91e5ceec into 2e1d79e683173691d…
evangeliaPanteliadou Jan 7, 2025
707f8cb
Update Stencil library version to 30.9.2--canary.1640.6267534476a062d…
invalid-email-address Jan 7, 2025
c92cb3e
Small adjustments in Sidebar and Tabs.
agata-kim Jan 8, 2025
2a82219
Merge branch '1566-storybook-consistency-and-ui-enhancement' of https…
agata-kim Jan 8, 2025
64bdc8d
Merge 2a822193ee4100b4fa1dc9077c5a54d518db59bf into 2e1d79e683173691d…
evangeliaPanteliadou Jan 8, 2025
750a6d5
Update Stencil library version to 30.9.2--canary.1640.64bdc8df6d06e0c…
invalid-email-address Jan 8, 2025
045b56e
Merge 750a6d5526493680ea8421f33d78c90b1cda6173 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 8, 2025
22e4499
Update Stencil library version to 30.9.2--canary.1640.64bdc8df6d06e0c…
invalid-email-address Jan 8, 2025
3fd840e
added condition to make sure func is invoked only for ifxChange comin…
tishoyanchev Jan 8, 2025
73e4e19
Merge 3fd840ec80a2a22bbe7c3a16bb6ebad764e673c3 into 2e1d79e683173691d…
evangeliaPanteliadou Jan 8, 2025
27da3d9
Update Stencil library version to 30.9.2--canary.1640.73e4e19bf6e56fa…
invalid-email-address Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhanced UI in Search Bar
agata-kim committed Nov 26, 2024
commit 98f60b68cd3485d315e341d79b66de1ffbefe24f
Original file line number Diff line number Diff line change
@@ -7,36 +7,88 @@ export default {
args: {
disabled: false,
isOpen: true,
value: '',
},
argTypes: {
ifxInput: {
action: 'ifxInput',
description: 'Custom event emitted on input\n\n(see below for Two Way Data Binding in different JS frameworks)',
isOpen: {
description: 'Search bar state',
control: { type: 'boolean' },
table:
{
category: 'ifx-search-bar props',
type: {
summary: 'boolean',
},
},
},
disabled: {
description: 'Search bar state',
control: { type: 'boolean' },
table:
{
category: 'ifx-search-bar props',
type: {
summary: 'boolean',
},
},
},
value: {
description: 'The value is used to handle the search bar input',
control: { type: 'text' },
table:
{
category: 'ifx-search-bar props',
type: {
summary: 'string',
},
},
},
maxlength: {
description: 'Maximum input length',
control: {type: 'number'}
control: { type: 'number' },
table:
{
category: 'ifx-search-bar props',
type: {
summary: 'number',
},
},
},
ifxSearchBarIsOpen: {
ifxInput: {
action: 'ifxInput',
description: 'Custom event',
description: 'Custom event emitted on input',
table: {
category: 'custom events',
type: {
summary: 'Framework integration',
detail: `React: onIfxInput={handleInput}\nVue:@ifxInput="handleInput"\nAngular:(ifxInput)="handleInput()"\nVanillaJs:.addEventListener("ifxInput", (event) => {//handle input});`,
}
}
},
ifxOpen: {
action: 'ifxOpen',
description: 'Custom event emitted when the state of *isOpen* changes',
table: {
category: 'custom events',
type: {
summary: 'Framework integration',
detail:
'React: onIfxInput={handleInput}\nVue:@ifxInput="handleInput"\nAngular:(ifxInput)="handleInput()"\nVanillaJs:.addEventListener("ifxInput", (event) => {//handle input});',
`React: onIfxOpen={handleOpen}\nVue:@ifxOpen="handleOpen"\nAngular:(ifxOpen)="handleOpen()"\nVanillaJs:.addEventListener("ifxOpen", (event) => {//handle open});`,
},
},
},
},
};

const DefaultTemplate = ({ isOpen, disabled, maxlength }) => {
const DefaultTemplate = ({ isOpen, disabled, maxlength, value }) => {
const element = document.createElement('ifx-search-bar');
element.setAttribute('is-open', isOpen);
element.setAttribute('disabled', disabled);
element.setAttribute('value', value);
element.addEventListener('ifxInput', action('ifxInput'));
if(maxlength != undefined) element.setAttribute('maxlength', maxlength);
element.addEventListener('ifxOpen', action('ifxOpen'));

if (maxlength != undefined) element.setAttribute('maxlength', maxlength);

return element;
};
8 changes: 4 additions & 4 deletions packages/components/src/components/search-bar/search-bar.tsx
Original file line number Diff line number Diff line change
@@ -13,12 +13,12 @@ export class SearchBar {
@Prop({ mutable: true }) value: string;
@Prop() maxlength?: number;
@Event() ifxInput: EventEmitter;
@Event() ifxSearchBarIsOpen: EventEmitter;
@Event() ifxOpen: EventEmitter;
@Element() el;

@Method()
async onNavbarMobile() {
this.ifxSearchBarIsOpen.emit(false)
this.ifxOpen.emit(false)
this.internalState = false;
}

@@ -29,7 +29,7 @@ export class SearchBar {

handleCloseButton = () => {
this.internalState = !this.internalState;
this.ifxSearchBarIsOpen.emit(this.internalState)
this.ifxOpen.emit(this.internalState)
}

setInitialState() {
@@ -40,7 +40,7 @@ export class SearchBar {

componentWillLoad() {
this.setInitialState();
this.ifxSearchBarIsOpen.emit(this.internalState)
this.ifxOpen.emit(this.internalState)
}