You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are we supposed to pass a string representation of the number via value? (i.e. "thirty")
Are label and value used correctly here? In my sense it should be the other way round. value should pass a number instead of string and returned on events, and label is displayed if required. {"value":"30","label":"thirty","selected":false}
Why are we supposed to pass a string representation of the number via value? (i.e. "thirty")
Are label and value used correctly here? In my sense it should be the other way round. value should pass a number instead of string and returned on events, and label is displayed if required. {"value":"30","label":"thirty","selected":false}
Hi @holley-ifx
You are not supposed to pass a string representation of the number. The "value" property could be anything you want. It is simply a required property of the select component, which is re-used in the pagination for setting the items-per-page.
Alternatively, I could remove the value property for users, and then add it internally. This would mean that users would only have to pass 'label' and 'selected' props in the object. Would this suffice?
This object {"value":"string","label":"string","selected": boolean} is required for the ifx-select component where the label is the contentText of the options, and the value is the value attribute. The ifx-select does emit an event, but it's not re-emitted for the pagination, as we don't think it's needed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tishoyanchev
changed the title
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Reference: #1665
📦 Published PR as canary version:
31.0.0--canary.1697.d182a3c648fcdb68889698ab9252e421f923fb47.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@31.0.0--canary.1697.d182a3c648fcdb68889698ab9252e421f923fb47.0 # or yarn add @infineon/infineon-design-system-stencil@31.0.0--canary.1697.d182a3c648fcdb68889698ab9252e421f923fb47.0