Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor misc cleanup #175

Merged
merged 13 commits into from
Aug 8, 2024
Merged

Minor misc cleanup #175

merged 13 commits into from
Aug 8, 2024

Conversation

jaenrig-ifx
Copy link
Member

@jaenrig-ifx jaenrig-ifx commented Aug 7, 2024 •
edited
Loading

⚠️ There are ci/cd failures which are being handled in separate PRs 👷‍♂️
As discussed:

  • Added machine.class to warning messages
  • Refactored VFS message prio banner
  • Removed WHD banner info
  • Removed double MicroPython banner
  • Removed irrelevant SIGPIPE

Additional:

  • Changed AP channel of wifi test to a less saturated channel in the HIL setup.

@jaenrig-ifx jaenrig-ifx force-pushed the ports-psoc6-main branch 2 times, most recently from daac77e to f41ff9c Compare August 8, 2024 08:55
@jaenrig-ifx jaenrig-ifx marked this pull request as ready for review August 8, 2024 09:28
ramya-subramanyam
ramya-subramanyam approved these changes Aug 8, 2024
View reviewed changes
Copy link

@ramya-subramanyam ramya-subramanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

NikhitaR-IFX
NikhitaR-IFX approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@NikhitaR-IFX NikhitaR-IFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just few questions on some changes.

ports/psoc6/help.c Outdated Show resolved Hide resolved
tests/ports/psoc6/hw_ext/sdcard.py Show resolved Hide resolved
IFX-Anusha
IFX-Anusha approved these changes Aug 8, 2024
View reviewed changes
ports/psoc6/help.c Outdated Show resolved Hide resolved
ports/psoc6/main.c Show resolved Hide resolved
@jaenrig-ifx
tests/ports/psoc6/multi/network: Chosen less saturated HIL env channel.
6367307 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
ports/psoc6: Unified warns. Removed redundant vbanners. Fixed help.
67a1f54 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
tests/psoc6/i2s: Updates .exp to new warn prints.
d14e340 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
ports/psoc6/main.c: Cleanup commented out code.
ff3b2e8 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
tests/ports/psoc6/uart: Expected changes.
11153ea 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
ports/psoc6/sdcard.py: Added warning ignored parameter.
706d4a1 
Signed-off-by: enriquezgarc <[email protected]>
@jaenrig-ifx
ports/psoc6/frezee: Formatted VFS message.
2f75d2f 
Signed-off-by: enriquezgarc <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:   +48 +0.012% PYBV10
     mimxrt:   +52 +0.014% TEENSY40
        rp2:   +56 +0.006% RPI_PICO_W
       samd:   +48 +0.018% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@jaenrig-ifx jaenrig-ifx merged commit cccea2d into ports-psoc6-main Aug 8, 2024
31 of 33 checks passed
@jaenrig-ifx jaenrig-ifx deleted the minor-misc-cleanup branch August 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikhitaR-IFX NikhitaR-IFX NikhitaR-IFX approved these changes

@IFX-Anusha IFX-Anusha IFX-Anusha approved these changes

@ederjc ederjc ederjc approved these changes

@ramya-subramanyam ramya-subramanyam ramya-subramanyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaenrig-ifx @ederjc @NikhitaR-IFX @IFX-Anusha @ramya-subramanyam