examples/imagimob: Adding imagimob mp integration. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikhitaR-IFX <[email protected]>
NikhitaR-IFX
requested review from
ederjc,
jaenrig-ifx,
IFX-Anusha and
ramya-subramanyam
Signed-off-by: NikhitaR-IFX <[email protected]>
Signed-off-by: NikhitaR-IFX <[email protected]>
jaenrig-ifx
reviewed
Aug 22, 2024
jaenrig-ifx
approved these changes
Aug 22, 2024
Signed-off-by: NikhitaR-IFX <[email protected]>
ramya-subramanyam
approved these changes
Aug 23, 2024
ports/psoc6/mpconfigport.h
Outdated
| @@ -220,6 +220,7 @@ extern void machine_deinit(); | |||
|
|
|||
| #define MICROPY_LOGGER_DEBUG (0) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Can this file be reverted as there are no changes here?
Signed-off-by: NikhitaR-IFX <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integration for imagimob and micropython.
Knowing this is the first version, it does the job fine for now. I have only tested to check if imports are working fine. Praveen is going to eventually use/extend this for the application he is working on.
I suggest we don't merge this to ports-psoc6-main and rather keep the changes alive in imai-mp-integration branch for now.
In case we see the need to extend this, then:
For reviewing, you can ignore the non-mpy files.
Testing
Details available in readme.md.