Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports/psoc6: Adding code for machine.Signal functionality. #77

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

NikhitaR-IFX
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description

  • Enables Signal module and available functions work.
  • Ideally, I would have wanted to reuse the APIs in driver but hal apis were more promising.
  • The tests/extmod/machine_signal.py should be passed but there are two problems:
  1. It depends on machine.PinBase which is another extmod extended by MPY but needs to enabled in our port.
  2. The value() is not used as it is mentioned here. The guide says value() returns undefined value which is how we implement in our por,t but the tests by mpy assume they return the digital value on that pin. Hence this test might not be useful even if we enable it.

@NikhitaR-IFX NikhitaR-IFX merged commit 45827ec into ports-psoc6-main Aug 11, 2023
18 of 20 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the machine-signal branch August 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants