Skip to content

docker: fix libpango1.0-dev package name #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

kon-foo
Copy link
Contributor

@kon-foo kon-foo commented Feb 22, 2025

Minor fix in the Dockerfiles apt installs: ibpango1.0-dev -> libpango1.0-dev.

This did not fail, because of apt-get fuzzy pattern matching:

apt-get install ibpango1.0-dev
...
Note, selecting 'libpango1.0-dev' for regex 'ibpango1.0-dev'

But it should still be fixed I guess.

Copy link

github-actions bot commented Feb 22, 2025

Build size and comparison to main:

Section Size Difference
text 375844B 0B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@mark9064
Copy link
Member

Not sure what's up with CI. Does something need updating? Change itself all looks good

@mark9064 mark9064 added the maintenance Background work label Feb 23, 2025
@NeroBurner NeroBurner added this to the 1.16.0 milestone May 29, 2025
@NeroBurner
Copy link
Contributor

could you rebase please. The GitHub Actions are now fixed. Sorry for the inconvenience

The change looks good. Good catch! I just want to make sure, that the CI jobs actually run successfully

@NeroBurner NeroBurner changed the title fixed libpango1.0-dev install docker: fix libpango1.0-dev package name May 30, 2025
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed. LGTM

@mark9064 mark9064 merged commit 8423ed6 into InfiniTimeOrg:main May 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Background work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants