refactor file & symlink #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2024
Misterio77
force-pushed
the
push-wowntlzvrlwy
branch
from
1fa6c09 to
c7c39bc
Compare
|
It seems that extended attributes don't work with symlinks :( I switched my approach to keeping the managed files listed in a text file |
Misterio77
force-pushed
the
push-wowntlzvrlwy
branch
2 times, most recently
from
c08b431 to
829076e
Compare
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading). I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
Misterio77
force-pushed
the
push-wowntlzvrlwy
branch
from
829076e to
ff02d46
Compare
Infinidoge
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I was still bothered by the fact that symlinks/files aren't cleaned up when removed from the config (and stopWhenChanged prevents us from using stuff such as reload), so I decided to try a different approach.
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).
I've also added support for directories (#73), and ensured only non-binary files are substituted with env vars (#70)
Marked as draft as I'm still testing it.
Fixes #73
Fixes #70