Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txt-file generation & docs symlinks/files value examples #103

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

arminius-smh
Copy link
Contributor

Hello,

two commits, one for the option to automatically infer and generate txt files, another for expanding the docs a bit on how
symlinks.value and files.value work.

I am not sure if Every option and example in symlinks works the same way for files is actually correct? It looked like it from the definitions of the options anyhow.
Just, when I was reading the docs, I didn't understand that I could just exchange it 1:1 and get the files instead of symlinks, since it just said they are "similiar", I didn't quite know what to do with that, which is I tried to clarify that a bit and added another example to the files.

Copy link
Contributor

@Misterio77 Misterio77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Misterio77
Copy link
Contributor

Can we merge this one, @Infinidoge?

@Infinidoge Infinidoge merged commit 6d93447 into Infinidoge:master Dec 29, 2024
@Infinidoge
Copy link
Owner

For future reference, it's best if PRs are 1 thing only, as it makes the final commit history cleaner :)

@arminius-smh
Copy link
Contributor Author

Sorry, yes ofc, I just did the changes concurrently for my issue and didn't think of it as two changes, which I also closed now, since this solution is good enough for me now

@arminius-smh arminius-smh deleted the txt-generation branch December 30, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants