Skip to content

Conversation

1000p
Copy link

@1000p 1000p commented Oct 3, 2025

Description πŸ“£

There was a typo for the golang arch used when building the image.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests πŸ› οΈ

N/A


Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR fixes a critical configuration bug in the GoReleaser setup for Docker image builds. The change corrects a typo on line 217 of `.goreleaser.yaml` where the ARM64 Docker build configuration incorrectly specified `goarch: amd64` instead of `goarch: arm64`.

The bug was in the second Docker configuration block (lines 215-226) which is specifically designed to build ARM64 images, as evidenced by the --platform=linux/arm64 build flag and the -arm64 suffix in the image templates. This inconsistency would have caused the build system to attempt creating ARM64 Docker images using AMD64 Go binaries, which could result in build failures or incorrectly architected images.

This fix is essential for the CLI's multi-architecture Docker support, ensuring that users on ARM64 systems (like Apple Silicon Macs and ARM64 servers) can properly pull and run the Infisical CLI Docker images. The change aligns the Go architecture specification with the intended platform configuration and image naming conventions already present in the file.

Changed Files
Filename Score Overview
.goreleaser.yaml 5/5 Fixed typo changing goarch: amd64 to goarch: arm64 for ARM64 Docker builds

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it's a straightforward typo fix
  • Score reflects a simple, well-understood configuration correction with clear intent
  • No files require special attention - the change is isolated and self-explanatory

Sequence Diagram

sequenceDiagram
    participant User
    participant "GoReleaser"
    participant "Docker Buildx"
    participant "Docker Registry"
    
    User->>GoReleaser: "Trigger release process"
    GoReleaser->>GoReleaser: "Parse .goreleaser.yaml config"
    GoReleaser->>GoReleaser: "Build binaries for all-other-builds"
    
    Note over GoReleaser: Build ARM64 binary with correct GOARCH
    GoReleaser->>GoReleaser: "Build linux/arm64 binary"
    
    GoReleaser->>Docker Buildx: "Build ARM64 Docker image"
    Docker Buildx->>Docker Buildx: "Use platform=linux/arm64"
    Docker Buildx->>Docker Registry: "Push infisical/cli:latest-arm64"
    
    GoReleaser->>Docker Buildx: "Build AMD64 Docker image"
    Docker Buildx->>Docker Buildx: "Use platform=linux/amd64"
    Docker Buildx->>Docker Registry: "Push infisical/cli:latest-amd64"
    
    GoReleaser->>Docker Registry: "Create multi-arch manifest"
    Docker Registry->>Docker Registry: "Combine ARM64 and AMD64 images"
    Docker Registry-->>User: "infisical/cli:latest manifest ready"
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant