feat: list secrets with etag support #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Jan 6, 2025
There was a problem hiding this comment.
This pr feels overly complex. Instead of doing comparisons, it might be better to only allow users pass in a etag -> the function will attach it to the header -> the function returns details along with a etag. The client can do what it wants with it.
Also in the context of the k8s operator, how will this change help the abrupt fetch by the k8s we once had? I thought the k8s already has logic in place to check if there are changes or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ETag comparisons support to the Go SDK. This is useful for applications depending on secret updates to perform certain actions, such as our K8 operator.