Skip to content

Fix tags middleware parsing #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tags middleware parsing #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/influxdb/rails/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ class Configuration
set_defaults(
measurement_name: "rails".freeze,
ignored_hooks: [].freeze,
tags_middleware: ->(tags) { tags },
tags_middleware: lambda { |tags|
tags.reject do |_key, value|
value.nil? || (value.is_a?(String) && value.squish.empty?)
end
},
rails_app_name: nil,
ignored_environments: %w[test cucumber selenium].freeze,
environment: ::Rails.env,
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/tags.rb → spec/unit/influx_db/rails/tags_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

it "removes empty strings" do
subject = described_class.new(config: config, tags: { hans: "", franz: " " })
expect(subject.to_h).not_to a_hash_including(hans: "", franz: " ")
expect(subject.to_h).not_to a_hash_including(:hans, :franz)
end

it "returns symbols" do
Expand All @@ -36,7 +36,7 @@

it "removes nil" do
subject = described_class.new(config: config, tags: { hans: nil })
expect(subject.to_h).not_to a_hash_including(hans: nil)
expect(subject.to_h).not_to a_hash_including(:hans)
end

it "leaves arrays alone" do
Expand Down