Skip to content

Commit

Permalink
add unit test for skip default
Browse files Browse the repository at this point in the history
  • Loading branch information
SimLi1333 committed Nov 26, 2024
1 parent 10c4cf9 commit e137f73
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions tests/test_conditional_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,50 @@ def test_initialization_with_invalid_limits(self) -> None:
group_fail_limits={"core": "x"}, # type: ignore[dict-item]
)

def test_skipped_task_is_in_result(self) -> None:
"""Test that a skipped task is recorded in the result."""
runner = ConditionalRunner(
num_workers=3,
group_limits={"core": 1},
skip_group_on_failure=True,
conditional_group_key="conditional_groups",
)

hosts = [
Host(name="core-01_fail", data={"conditional_groups": ["core"]}),
Host(name="core-02", data={"conditional_groups": ["core"]}),
]

result = runner.run(self.task, hosts)

# Verify result contains skipped host
self.assertIn("core-02", result)
self.assertTrue(result["core-02"].failed)
self.assertEqual(
str(result["core-02"].exception),
"Skipped due to failure limit for group 'core'",
)

def test_skipped_task_is_not_in_result(self) -> None:
"""Test that a skipped task is recorded in the result."""
runner = ConditionalRunner(
num_workers=3,
group_limits={"core": 1},
skip_group_on_failure=False,
conditional_group_key="conditional_groups",
)

hosts = [
Host(name="core-01_fail", data={"conditional_groups": ["core"]}),
Host(name="core-02", data={"conditional_groups": ["core"]}),
]

result = runner.run(self.task, hosts)

# Verify result contains skipped host
self.assertIn("core-02", result)
self.assertFalse(result["core-02"].failed)


if __name__ == "__main__":
unittest.main()

0 comments on commit e137f73

Please sign in to comment.