Merge pull request #1800 from Inist-CNRS/fix-enrichment-size

fix: ensure BATCH_SIZE is a Number
Inist-CNRS · Nov 27, 2023 · 96779db · 96779db
2 parents 12d34e6 + 23fb53e
commit 96779db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/api/services/enrichment/enrichment.js b/src/api/services/enrichment/enrichment.js
@@ -43,7 +43,8 @@ const getSourceData = async (ctx, sourceColumn) => {
 };
 
 export const createEnrichmentRule = async (ctx, enrichment) => {
-    const { enrichmentBatchSize: BATCH_SIZE = 10 } = ctx.configTenant;
+    const { enrichmentBatchSize } = ctx.configTenant;
+    const BATCH_SIZE = Number(enrichmentBatchSize || 10);
     if (enrichment.advancedMode) {
         return enrichment;
     }
@@ -67,7 +68,8 @@ const cleanWebServiceRule = rule => {
 };
 
 export const getEnrichmentDataPreview = async ctx => {
-    const { enrichmentBatchSize: BATCH_SIZE = 10 } = ctx.configTenant;
+    const { enrichmentBatchSize } = ctx.configTenant;
+    const BATCH_SIZE = Number(enrichmentBatchSize || 10);
     const { sourceColumn, subPath, rule } = ctx.request.body;
     let previewRule = rule;
     if (!sourceColumn && !rule) {
@@ -223,7 +225,8 @@ const processEzsEnrichment = (entries, commands, ctx, preview = false) => {
 };
 
 export const processEnrichment = async (enrichment, ctx) => {
-    const { enrichmentBatchSize: BATCH_SIZE = 10 } = ctx.configTenant;
+    const { enrichmentBatchSize } = ctx.configTenant;
+    const BATCH_SIZE = Number(enrichmentBatchSize || 10);
     await ctx.enrichment.updateStatus(enrichment._id, IN_PROGRESS);
     let errorCount = 0;
 

diff --git a/src/app/js/admin/configTenant/ConfigTenantForm.js b/src/app/js/admin/configTenant/ConfigTenantForm.js
@@ -227,9 +227,10 @@ export const ConfigTenantForm = ({
             <TextField
                 label="Enrichment Batch Size"
                 value={enrichmentBatchSize || ''}
+                type="number"
                 sx={{ mb: 2 }}
                 onChange={event => {
-                    setEnrichmentBatchSize(event.target.value);
+                    setEnrichmentBatchSize(Number(event.target.value));
                 }}
             />
             <Box sx={{ mb: 10 }}>