Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inspire Loader #1698

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Update Inspire Loader #1698

merged 5 commits into from
Sep 20, 2023

Conversation

touv
Copy link
Contributor

@touv touv commented Sep 4, 2023

No description provided.

@touv touv added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Sep 4, 2023

#loader json-inspirehep.ini (version juin 2023 - Inist-CNRS)

append = dump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiens? Ça marche indifféremment avec pack et avec dump ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien vu, depuis que les loaders sont intégrés directement dans lodex, il faut utiliser pack et pas dump.
La communication avec lodex se fait en jsonl et non en json

@parmentf
Copy link
Contributor

parmentf commented Sep 4, 2023

Je suppose que la date de chargement n'est pas jugée utile, car la partie où elle était ajoutée a été supprimée.

@touv
Copy link
Contributor Author

touv commented Sep 4, 2023

si évidemment, j'ai juste copier coller le fichier, tous les loaders doivent avoir les mêmes instructions à la fin.

  • pour le controle des noms de champs
  • pour l'ajout d'un stamp

Comment on lines +70 to +71
[OBJFlatten]
separator = /
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette instruction est-elle vraiment souhaitée ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honnêtement je ne me rappelle plus.
Il faudrait voir le modèle correspondant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en attendant, on peut laisser

@touv touv merged commit 2f07253 into master Sep 20, 2023
6 checks passed
@touv touv deleted the update-inspire-loader branch September 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants