Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an advanced mode to vega / vega lite chart #1704

Merged
merged 39 commits into from
Oct 10, 2023
Merged

Conversation

AlasDiablo
Copy link
Collaborator

@AlasDiablo AlasDiablo commented Sep 14, 2023

  • Vega Lite
    • bar chart
    • bubble plot
    • cartography
    • heatmap
    • pie chart
  • Vega
    • flow map
    • radar chart
  • Admin panel
    • Add a translation to the rest button
    • Use a correct color for the rest button
  • Other refactor
    • add comment to not easily understandable function
    • convert view component to function component
      • bar chart
      • bubble plot
      • cartography
      • heatmap
      • pie chart
      • flow map
      • radar chart

Error message

Screenshot_20231002_100517

@AlasDiablo AlasDiablo added Trello 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée labels Sep 14, 2023
@AlasDiablo AlasDiablo self-assigned this Sep 14, 2023
@AlasDiablo AlasDiablo marked this pull request as draft September 14, 2023 13:55
@AlasDiablo AlasDiablo removed the 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée label Sep 15, 2023
@AlasDiablo AlasDiablo marked this pull request as ready for review September 18, 2023 08:23
AlasDiablo and others added 2 commits September 18, 2023 15:34
Co-authored-by: François Parmentier <[email protected]>
Co-authored-by: François Parmentier <[email protected]>
@AlasDiablo AlasDiablo marked this pull request as draft September 20, 2023 05:27
@AlasDiablo AlasDiablo marked this pull request as ready for review September 22, 2023 10:58
@AlasDiablo AlasDiablo added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Sep 22, 2023
Copy link
Contributor

@touv touv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for later: add a specific test for each graph

src/app/js/formats/vega-lite/models/BarChart.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/Cartography.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/HeatMap.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/PieChart.js Outdated Show resolved Hide resolved
src/app/js/formats/vega/models/FlowMap.js Outdated Show resolved Hide resolved
cypress/integration/graph_page.spec.js Outdated Show resolved Hide resolved
cypress/integration/graph_page.spec.js Outdated Show resolved Hide resolved
cypress/integration/model.spec.js Outdated Show resolved Hide resolved
cypress/integration/model.spec.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/Cartography.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/HeatMap.js Outdated Show resolved Hide resolved
src/app/js/formats/vega-lite/models/PieChart.js Outdated Show resolved Hide resolved
src/app/js/formats/vega/models/FlowMap.js Outdated Show resolved Hide resolved
src/app/js/formats/vega/models/RadarChart.js Outdated Show resolved Hide resolved
@touv
Copy link
Contributor

touv commented Oct 6, 2023

si les modifications de François sont prises en compte peut-être que cette PR pourrait être mergée ...

Sinon, je pense qu'il aurait été plus simple à relire de faire une PR par graphique, même si il s'agit du même type de modification. à voir ce qu'en pense @parmentf

@touv touv self-requested a review October 10, 2023 07:50
@touv touv merged commit 84312b6 into master Oct 10, 2023
6 checks passed
@AlasDiablo AlasDiablo deleted the add-advanced-chart-params branch October 10, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants