Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and unify mongodb version with ezsLodex #1719

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Update and unify mongodb version with ezsLodex #1719

merged 13 commits into from
Oct 16, 2023

Conversation

AlasDiablo
Copy link
Collaborator

No description provided.

@AlasDiablo AlasDiablo marked this pull request as ready for review October 9, 2023 06:26
parmentf
parmentf reviewed Oct 9, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@AlasDiablo AlasDiablo added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Oct 10, 2023
@parmentf
Copy link
Contributor

There is still a test failing:

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  ZLIB

      at Object.<anonymous> (../../../node_modules/@mongodb-js/saslprep/src/code-points-data.ts:3:26)
      at Object.<anonymous> (../../../node_modules/@mongodb-js/saslprep/src/memory-code-points.ts:2:1)

@AlasDiablo
Copy link
Collaborator Author

AlasDiablo commented Oct 10, 2023 •
edited
Loading

There is still a test failing:

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  ZLIB

      at Object.<anonymous> (../../../node_modules/@mongodb-js/saslprep/src/code-points-data.ts:3:26)
      at Object.<anonymous> (../../../node_modules/@mongodb-js/saslprep/src/memory-code-points.ts:2:1)

A part of this problem come from the master branch.
But we can wait of a fix.

@AlasDiablo AlasDiablo mentioned this pull request Oct 11, 2023
Merged
@touv touv merged commit 0df8a35 into master Oct 16, 2023
6 checks passed
@AlasDiablo AlasDiablo deleted the npm-update-mongodb branch October 16, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@touv touv touv approved these changes

@parmentf parmentf parmentf approved these changes

Assignees
No one assigned
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlasDiablo @parmentf @touv