fix: skip validation flag in subUnockedCoins()

InjectiveLabs · Jun 10, 2024 · fc7ff68 · fc7ff68
1 parent bc84b8c
commit fc7ff68
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/x/bank/keeper/keeper.go b/x/bank/keeper/keeper.go
@@ -183,7 +183,7 @@ func (k BaseKeeper) UndelegateCoins(ctx context.Context, moduleAccAddr, delegato
 		return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, amt.String())
 	}
 
-	err := k.subUnlockedCoins(ctx, moduleAccAddr, amt)
+	err := k.subUnlockedCoins(ctx, moduleAccAddr, amt, false)
 	if err != nil {
 		return err
 	}
@@ -393,7 +393,7 @@ func (k BaseKeeper) BurnCoins(ctx context.Context, moduleName string, amounts sd
 		panic(errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "module account %s does not have permissions to burn tokens", moduleName))
 	}
 
-	err := k.subUnlockedCoins(ctx, acc.GetAddress(), amounts)
+	err := k.subUnlockedCoins(ctx, acc.GetAddress(), amounts, false)
 	if err != nil {
 		return err
 	}

diff --git a/x/bank/keeper/send.go b/x/bank/keeper/send.go
@@ -170,7 +170,7 @@ func (k BaseSendKeeper) InputOutputCoins(ctx context.Context, input types.Input,
 		}
 	}
 
-	err = k.subUnlockedCoins(ctx, inAddress, input.Coins)
+	err = k.subUnlockedCoins(ctx, inAddress, input.Coins, true)
 	if err != nil {
 		return err
 	}
@@ -222,7 +222,7 @@ func (k BaseSendKeeper) SendCoins(ctx context.Context, fromAddr, toAddr sdk.AccA
 		return err
 	}
 
-	err = k.subUnlockedCoins(ctx, fromAddr, amt)
+	err = k.subUnlockedCoins(ctx, fromAddr, amt, true)
 	if err != nil {
 		return err
 	}
@@ -297,9 +297,12 @@ func (k BaseSendKeeper) validateCoinsBeforeSend(ctx context.Context, addr sdk.Ac
 // subUnlockedCoins removes the unlocked amt coins of the given account. An error is
 // returned if the resulting balance is negative or the initial amount is invalid.
 // A coin_spent event is emitted after.
-func (k BaseSendKeeper) subUnlockedCoins(ctx context.Context, addr sdk.AccAddress, amt sdk.Coins) error {
-	if err := k.validateCoinsBeforeSend(ctx, addr, amt); err != nil {
-		return err
+func (k BaseSendKeeper) subUnlockedCoins(ctx context.Context, addr sdk.AccAddress, amt sdk.Coins, skipValidation bool) error {
+	if !skipValidation {
+		err := k.validateCoinsBeforeSend(ctx, addr, amt)
+		if err != nil {
+			return err
+		}
 	}
 
 	for _, coin := range amt {