Injective Cherry Picks for v0.50.x #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+30
to
+32
| ctx.EventManager().EmitTypedEvent(&types.EventSetBalances{ | ||
| BalanceUpdates: balanceUpdates, | ||
| }) |
Check warning
Code scanning / gosec
Errors unhandled. Warning
|
|
||
| // EndBlocker is called every block, emits balance event | ||
| func EndBlocker(ctx sdk.Context, k keeper.Keeper) { | ||
| k.EmitAllTransientBalances(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| // EndBlock returns the end blocker for the bank module. It returns no validator | ||
| // updates. | ||
| func (am AppModule) EndBlock(ctx context.Context) error { | ||
| EndBlocker(sdk.UnwrapSDKContext(ctx), am.keeper) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
@alexanderbez your pull request is missing a changelog! |
alexanderbez
commented
Dec 20, 2023
| // Below are the long-lived replace of the Cosmos SDK | ||
| replace ( | ||
| cosmossdk.io/store => github.com/InjectiveLabs/cosmos-sdk/store v0.1.0-alpha.1.0.20231219011149-dc1791121e91 |
There was a problem hiding this comment.
We'll have to pin this to an explicit version once we tag.
kakysha
pushed a commit
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
release/v0.50.xbranch to injective's forkv0.47.3-inj-8Note, I realized there is a different naming convention in injective, so lmk if we should rename the base branch to
f/v0.50.x-inj.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change