Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add round to FPDecimal, fix a bug in must_from_str #174

Merged
merged 6 commits into from
Sep 14, 2023
Merged

add round to FPDecimal, fix a bug in must_from_str #174

merged 6 commits into from
Sep 14, 2023

Conversation

DrunkenRandomWalker
Copy link
Collaborator

@DrunkenRandomWalker DrunkenRandomWalker commented Sep 13, 2023 •
edited
Loading

  1. Add round to FPDecimal
  2. FPDecimal::must_from_str("-0") returns FPDeciaml::ZERO.

gorgos
gorgos reviewed Sep 13, 2023
View reviewed changes
packages/injective-math/src/utils.rs Show resolved Hide resolved
packages/injective-math/src/utils.rs Outdated Show resolved Hide resolved
packages/injective-math/src/utils.rs Show resolved Hide resolved
gorgos
gorgos reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@gorgos gorgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good

packages/injective-math/src/utils.rs Outdated Show resolved Hide resolved
packages/injective-math/src/utils.rs Outdated Show resolved Hide resolved
@gorgos gorgos merged commit fd10d48 into dev Sep 14, 2023
4 checks passed
@DrunkenRandomWalker DrunkenRandomWalker deleted the f/round branch September 14, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorgos gorgos gorgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrunkenRandomWalker @gorgos