Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added exchange params to injective-cosmwasm #175

Merged
merged 3 commits into from
Sep 19, 2023
Merged

added exchange params to injective-cosmwasm #175

merged 3 commits into from
Sep 19, 2023

Conversation

maxrobot
Copy link
Contributor

No description provided.

@maxrobot maxrobot requested a review from gorgos September 18, 2023 13:55
gorgos
gorgos requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@gorgos gorgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good!

packages/injective-cosmwasm/src/querier.rs Outdated Show resolved Hide resolved
packages/injective-cosmwasm/src/exchange/response.rs Show resolved Hide resolved
gorgos
gorgos approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@gorgos gorgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so you are not blocked but see above

@maxrobot maxrobot merged commit 5f7faed into dev Sep 19, 2023
4 checks passed
@maxrobot maxrobot deleted the f/exchange-params branch September 19, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorgos gorgos gorgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxrobot @gorgos