-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/injective-math improvements #186
Conversation
…in when x is small
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good step to making the package better but can we:
- make sure there is a consistent interface
Meaning that all public functions are not underscored, and if they are not to be public the to perform that at the function definition level
Keep mathematical operations like power, exp, sqrt available.
-
Also remove uncommented code
-
There is use of unwrap which I think is unsafe, please make sure we are handling unwraps appropriately.
1 and 2 are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good, although I cant go through the math in detail of course, hopefully the tests and us using the new version will be sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bigint
withprimitive-types
, becausebigint
is deprecated.exp
,pow
, andln
numerical precision to double precision.