-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix trust wallet #400
Conversation
WalkthroughThis update involves a minor yet crucial adjustment in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/wallet-ts/src/strategies/wallet-strategy/strategies/TrustWallet/index.ts (1 hunks)
Additional comments: 1
packages/wallet-ts/src/strategies/wallet-strategy/strategies/TrustWallet/index.ts (1)
- 131-131: The change in the order of parameters from
[address, eip712json]
to[eip712json, address]
in theparams
array for theethereum.request
method call aligns with the PR's objective to fix the Trust Wallet issue. This adjustment is crucial for ensuring compatibility with Trust Wallet's expected parameter order for theeth_signTypedData_v4
method. The modification appears to be correctly implemented and directly addresses the identified issue.
Hello,
Right now Trust wallet is not working on the production and dev https://helixapp.com/
This pull request fixes Trust wallet.
Here, you can find where the problem is:
https://github.com/trustwallet/trust-web3-provider/blob/2bfd36ade2ac2275782969dcae5ac6bf3d608054/src/ethereum_provider.js#L305
trustwallet/trust-web3-provider#505
Team: Qwerty.Exchange
Summary by CodeRabbit