Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix trust wallet #400

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

Grinion
Copy link
Contributor

@Grinion Grinion commented Feb 22, 2024

Hello,

Right now Trust wallet is not working on the production and dev https://helixapp.com/

This pull request fixes Trust wallet.

Here, you can find where the problem is:
https://github.com/trustwallet/trust-web3-provider/blob/2bfd36ade2ac2275782969dcae5ac6bf3d608054/src/ethereum_provider.js#L305

trustwallet/trust-web3-provider#505

Team: Qwerty.Exchange

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the parameter order in TrustWallet requests to enhance compatibility and functionality.

Copy link

coderabbitai bot commented Feb 22, 2024

Walkthrough

This update involves a minor yet crucial adjustment in the TrustWallet strategy implementation, specifically in the way parameters are passed to the ethereum.request method. The sequence of parameters has been revised, swapping the positions of the user's address and the EIP-712 formatted JSON object to enhance compatibility or functionality.

Changes

File Path Change Summary
.../wallet-strategy/strategies/TrustWallet/index.ts Swapped parameter order in params array from [address, eip712json] to [eip712json, address] in ethereum.request call.

🐰✨
In the land of code, where the bits do leap,
A tiny change, in the digital deep.
Swapped around, with a hop so light,
[eip712json, address] now just right.
In TrustWallet's realm, the rabbits cheer,
For smoother transactions are now here!
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between db257db and 907f63f.
Files selected for processing (1)
  • packages/wallet-ts/src/strategies/wallet-strategy/strategies/TrustWallet/index.ts (1 hunks)
Additional comments: 1
packages/wallet-ts/src/strategies/wallet-strategy/strategies/TrustWallet/index.ts (1)
  • 131-131: The change in the order of parameters from [address, eip712json] to [eip712json, address] in the params array for the ethereum.request method call aligns with the PR's objective to fix the Trust Wallet issue. This adjustment is crucial for ensuring compatibility with Trust Wallet's expected parameter order for the eth_signTypedData_v4 method. The modification appears to be correctly implemented and directly addresses the identified issue.

@bangjelkoski bangjelkoski merged commit 58aed18 into InjectiveLabs:dev Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants