F/docker #83
Merged
F/docker #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ri-go
commented
Apr 13, 2023
Ri-go
commented
- Nonroot container
- multiarch release
achilleas-kal
requested changes
Apr 13, 2023
.github/workflows/docker.yml
Outdated
| - 'v*' | ||
| - v** | ||
| env: | ||
| ECR_ENABLED: false |
There was a problem hiding this comment.
Shouldn't this be the other way around? ECR enabled but GHCR disabled?
There was a problem hiding this comment.
Saw that we have a GHCR for this so I flicked it. Should I revert?
There was a problem hiding this comment.
We can push on GHCR too but on ECR for sure, everything is on ECR including peggo and testnet validators get images from there too.
We can consider a move to GHCR later for all images.
nmarcetic
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.