fix/solve memory leak issue (#138)

* (fix) Change to ensure the chain cookie file is released after reading it. Close cometbft connection when the client instance is closed. * (fix) Solved error when closing the cookie file --------- Co-authored-by: Abel Armoa <[email protected]>
InjectiveLabs · Jun 4, 2023 · d5dbabe · d5dbabe
1 parent 0b80e40
commit d5dbabe
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/client/chain/chain.go b/client/chain/chain.go
@@ -272,7 +272,11 @@ func NewChainClient(
 	}
 
 	// create file if not exist
-	os.OpenFile(defaultChainCookieName, os.O_RDONLY|os.O_CREATE, 0666)
+	cookie_file, err := os.OpenFile(defaultChainCookieName, os.O_RDONLY|os.O_CREATE, 0666)
+	if err != nil {
+		cc.logger.Errorln(err)
+	}
+	defer cookie_file.Close()
 
 	// attempt to load from disk
 	data, err := os.ReadFile(defaultChainCookieName)
@@ -480,6 +484,10 @@ func (c *chainClient) Close() {
 	if c.conn != nil {
 		c.conn.Close()
 	}
+
+	if c.cometbftClient != nil {
+		c.cometbftClient.Stop()
+	}
 }
 
 func (c *chainClient) GetBankBalances(ctx context.Context, address string) (*banktypes.QueryAllBalancesResponse, error) {