Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update chain proto definitions to 1.12.1 #205

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Jan 25, 2024

  • Updated all proto definitions to sync the SDK with the new injective-core version 1.12.1 in mainnet
  • Updated .ini files for markets and tokens
  • Removed unused network parameter in the new functions CreateSpotOrder and CreateDerivativeOrder in ChainClient

abel added 2 commits January 25, 2024 12:01
…Updated CreateSpotOrder and CreateDerivativeOrder functions to remove the unused variable network
…est(fix) Fixed failing test(fix) Fixed failing test(fix) Fixed failing test(fix) Fixed failing test(fix) Fixed failing test(fix) Fixed failing test
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5aa9b38) 29.71% compared to head (43c14f7) 29.71%.

Files Patch % Lines
client/chain/chain.go 0.00% 4 Missing ⚠️
client/chain/chain_test_support.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   29.71%   29.71%           
=======================================
  Files          17       17           
  Lines        2564     2564           
=======================================
  Hits          762      762           
  Misses       1766     1766           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmoa aarmoa merged commit a520a72 into master Jan 25, 2024
3 of 4 checks passed
@aarmoa aarmoa deleted the fix/update_chain_proto_definitions_to_1_12_1 branch January 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant