Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cookies_management_refactoring #215

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Apr 9, 2024

  • Changed the logic that processes cookies, to try and get the new cookie from any gRPC call response.
  • Removed the extra initial request to get the cookie

Closes CHAIN-21

Summary by CodeRabbit

  • New Features
    • Introduced a new mechanism for executing API and stream calls with enhanced cookie handling support.
  • Refactor
    • Improved cookie management across the application, including automatic handling of cookie expiration and metadata.
    • Streamlined network-related code by consolidating common functionality and renaming for clarity.
    • Centralized RPC call execution to reduce redundancy and simplify codebase.
  • Bug Fixes
    • Adjusted cookie expiration time calculation and parsing logic to ensure accurate handling of cookie metadata.

@aarmoa aarmoa requested a review from nicolasbaum April 9, 2024 18:58
Copy link

coderabbitai bot commented Apr 9, 2024

Walkthrough

The recent updates streamline API and stream calls with centralized execution and improved cookie management. Changes across various components enhance network communications by refining cookie handling and promoting code reuse. The modifications aim to boost efficiency and maintainability in the codebase.

Changes

Files Change Summary
.../api_request_assistant.go Introduced for executing API/stream calls with cookie handling.
.../network.go, .../network_test.go Enhanced cookie management, method updates, and struct field naming.
.../exchange/exchange.go, .../explorer/explorer.go Refactored to use a common execution function for RPC calls, improving code reuse and consistency.

🐰✨
Changes afoot in the code, so neat,
With cookies managed, oh what a feat!
Across the files, the updates dance,
Bringing efficiency in every glance.
Here's to the code, now sleek and bright,
A rabbit's cheer for progress in sight!
🌟🐾


Recent Review Status

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 86991f4 and 7ac3f58.
Files selected for processing (2)
  • client/common/api_request_assistant.go (1 hunks)
  • client/exchange/exchange.go (67 hunks)
Files skipped from review as they are similar to previous changes (2)
  • client/common/api_request_assistant.go
  • client/exchange/exchange.go

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aarmoa aarmoa merged commit f7b8238 into dev Apr 10, 2024
4 checks passed
@aarmoa aarmoa deleted the feat/cookies_management_refactoring branch April 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants