-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/fix_readme_installation #223
Conversation
WalkthroughThe primary change involves updating the installation process for Go dependencies in the Changes
Assessment against linked issues
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
README.md (3)
Line range hint
34-34
: Consider adding a note that themake copy-exchange-client
command requires theinjective-indexer
repository to be cloned as mentioned.
Line range hint
44-47
: Consider using a pull request workflow instead of pushing directly to master for better collaboration and review.
Line range hint
67-67
: Remove the colon after "under" to correct the grammatical structure.- Originally released by Injective Labs Inc. under: + Originally released by Injective Labs Inc. under
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional Context Used
LanguageTool (2)
README.md (2)
Near line 63: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...` --- ## License Copyright © 2020 - 2022 Injective Labs Inc. (https://inject...
Near line 67: Do not use a colon (:) before a series that is introduced by a preposition (‘under’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ...ginally released by Injective Labs Inc. under:
Apache License
Version 2....
Markdownlint (13)
README.md (13)
12: null
Dollar signs used before commands without showing output
13: null
Dollar signs used before commands without showing output
14: null
Dollar signs used before commands without showing output
34: null
Dollar signs used before commands without showing output
44: null
Dollar signs used before commands without showing output
45: null
Dollar signs used before commands without showing output
46: null
Dollar signs used before commands without showing output
47: null
Dollar signs used before commands without showing output
17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
18: null
Fenced code blocks should be surrounded by blank lines
63: null
Bare URL used
70: null
Bare URL used
65: null
Images should have alternate text (alt text)
Additional comments not posted (1)
README.md (1)
14-14
: Change approved: Switch fromgo install ./...
togo mod download
should help resolve dependency issues on specific architectures.
Fixes #222
Summary by CodeRabbit
go mod download
instead ofgo install ./...
for installing dependencies in thesdk-go
repository.