Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix/solve) Solve ofac.json path issue #244

Merged
merged 4 commits into from
Sep 25, 2024
Merged

(fix/solve) Solve ofac.json path issue #244

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6de017
(fix/solve) Solve ofac.json path issue
shibaeff Sep 23, 2024
4700140
(fix/solve) Fix linting
shibaeff Sep 23, 2024
fef78fa
(fix/solve) Fix path derivation for OFAC
shibaeff Sep 24, 2024
a6ba870
(fix/solve) Refactor to avoid using directory separator
shibaeff Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions client/chain/ofac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import (
"io"
"net/http"
"os"
"path/filepath"
"strings"
)

const (
Expand Down Expand Up @@ -40,11 +38,7 @@ func NewOfacChecker() (*OfacChecker, error) {
}

func getOfacListPath() string {
currentDirectory, _ := os.Getwd()
for !strings.HasSuffix(currentDirectory, "sdk-go") {
currentDirectory = filepath.Dir(currentDirectory)
}
return filepath.Join(filepath.Join(filepath.Join(currentDirectory, "client"), "metadata"), ofacListFilename)
return getFileAbsPath(fmt.Sprintf("../metadata/%s", ofacListFilename))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not make assumptions regarding the directory separator used by the OS. To create a path we should be using path.Join

}

func DownloadOfacList() error {
Expand Down
Loading