Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add chain streams support #243

Merged
merged 22 commits into from
Nov 1, 2023
Merged

Feat/add chain streams support #243

merged 22 commits into from
Nov 1, 2023

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Sep 7, 2023

  • Added support for chain streams and a new example module.

@aarmoa aarmoa marked this pull request as draft September 7, 2023 14:29
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (cb38b09) 56.66% compared to head (1f053da) 56.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #243      +/-   ##
==========================================
- Coverage   56.66%   56.59%   -0.07%     
==========================================
  Files          17       17              
  Lines        2042     2071      +29     
  Branches      241      240       -1     
==========================================
+ Hits         1157     1172      +15     
- Misses        848      862      +14     
  Partials       37       37              
Files Coverage Δ
pyinjective/async_client.py 50.90% <66.66%> (+0.18%) ⬆️
pyinjective/core/network.py 42.62% <18.18%> (+1.98%) ⬆️
pyinjective/composer.py 50.28% <41.37%> (-1.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmoa aarmoa marked this pull request as ready for review October 9, 2023 20:30
@aarmoa
Copy link
Collaborator Author

aarmoa commented Oct 9, 2023

The code coverage in the PR decreases a little bit. But it will be increased in the PR we are preparing to add the low level components in the SDK that the TS SDK has



async def main() -> None:
network = Network.devnet()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the examples point to testnet, for consistency it's best we use testnet here too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change this

@aarmoa
Copy link
Collaborator Author

aarmoa commented Oct 11, 2023

Changes are ready to be merged. I am just waiting for a confirmation on the chain stream endpoints for the different networks

@aarmoa aarmoa merged commit 75b7807 into dev Nov 1, 2023
10 of 12 checks passed
@aarmoa aarmoa deleted the feat/add_chain_streams_support branch November 6, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants