feat/add_tia_usdt_spot_market #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aarmoa
commented
Nov 6, 2023
aarmoa
commented
- Added TIA/USDT spot market in mainnet and testnet ini file
… testnet ini files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 56.30% 56.30%
=======================================
Files 17 17
Lines 2039 2039
Branches 241 241
=======================================
Hits 1148 1148
Misses 855 855
Partials 36 36 ☔ View full report in Codecov by Sentry. |
| base = 6 | ||
| quote = 6 | ||
| min_price_tick_size = 0.001 | ||
| min_display_price_tick_size = 9.999999999999999e-05 |
There was a problem hiding this comment.
could it be 0.001? (although it won't effect API result)
There was a problem hiding this comment.
Sorry @vinhphuctadang, I had to release a new version of the SDK including the market in a rush, and I did not get to see your comment on time.
I will apply the change in a separate PR tomorrow my time
There was a problem hiding this comment.
no worries, I checked it won't effect trading API so please help when you're up, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.