Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add new indexer position endpoints #284

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Dec 20, 2023

  • Added logic to provide access to the new AccountPortfolioBalances and PositionsV2 endpoints provided by Indexer

…nces` and `PositionsV2` endpoints provided by Indexer
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b0ffc20) 71.91% compared to head (33436cc) 72.00%.

Files Patch % Lines
pyinjective/async_client.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #284      +/-   ##
==========================================
+ Coverage   71.91%   72.00%   +0.08%     
==========================================
  Files          46       46              
  Lines        3141     3150       +9     
  Branches      284      284              
==========================================
+ Hits         2259     2268       +9     
  Misses        814      814              
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinhphuctadang vinhphuctadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aarmoa aarmoa merged commit 2aeca6a into dev Dec 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants