Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/use dot env in examples #301

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Feat/use dot env in examples #301

merged 2 commits into from
Feb 6, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Feb 6, 2024 •
edited
Loading

  • Refactored all examples to remove hardcoded private keys in favor of taking them from environment variables
  • Added the use of pythong-dotenv package to load environment variables from .env files
  • Removed asyncio package dependency

Fixes #254

(feat) Refactored all examples to remove references to private keys. …
ca0c2ce 
…Added the use of `dotenv` to load private keys into environment variables. Removed `asyncio` package dependency
nicolasbaum
nicolasbaum approved these changes Feb 6, 2024
View reviewed changes
Copy link

@nicolasbaum nicolasbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to load env variables instead of hardcoded values. Approved

This was referenced Feb 6, 2024
Closed
Closed
@aarmoa aarmoa merged commit fe3bb32 into dev Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbaum nicolasbaum nicolasbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarmoa @nicolasbaum