-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/fix_example_script_errors #310
Conversation
WalkthroughThe changes involve refining the functionality of a chain client's exchange module, particularly focusing on derivatives. The adjustments include removing an obsolete parameter and shifting the focus from spot orders to derivative orders across various query functions. This refocuses the module towards a more specialized domain of financial instruments. Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #310 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 50 50
Lines 4111 4111
Branches 351 351
=======================================
Hits 3131 3131
Misses 875 875
Partials 105 105 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (4)
- examples/chain_client/exchange/13_MsgInstantBinaryOptionsMarketLaunch.py (1 hunks)
- examples/chain_client/exchange/query/23_TraderDerivativeOrders.py (1 hunks)
- examples/chain_client/exchange/query/24_AccountAddressDerivativeOrders.py (1 hunks)
- examples/chain_client/exchange/query/25_DerivativeOrdersByHashes.py (1 hunks)
Additional comments: 4
examples/chain_client/exchange/query/24_AccountAddressDerivativeOrders.py (1)
- 27-27: The change from
fetch_chain_account_address_spot_orders
tofetch_chain_account_address_derivative_orders
correctly aligns the example script with the intended functionality of fetching derivative orders. This update is crucial for maintaining the accuracy and relevance of the example scripts provided to users. Good job on making this change.examples/chain_client/exchange/query/23_TraderDerivativeOrders.py (1)
- 29-29: The update to use
fetch_chain_trader_derivative_orders
instead offetch_chain_trader_spot_orders
is a significant improvement that ensures the example script accurately demonstrates fetching derivative orders. This change is in line with the PR's objectives and enhances the script's relevance and utility for users. Well done on this update.examples/chain_client/exchange/query/25_DerivativeOrdersByHashes.py (1)
- 29-29: The modification to use
fetch_chain_derivative_orders_by_hashes
instead offetch_chain_spot_orders_by_hashes
correctly updates the example script to fetch derivative orders by hashes. This change enhances the script's accuracy and relevance for users, aligning with the PR's objectives to improve the example scripts. Excellent work on making this update.examples/chain_client/exchange/13_MsgInstantBinaryOptionsMarketLaunch.py (1)
- 39-44: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of the
quote_decimals
parameter from the function call within themain
function is a thoughtful update that likely aligns with updated API requirements or corrects a previously incorrect usage. This change ensures the example script remains accurate and relevant, contributing to the PR's objectives of improving the example scripts. Good job on making this adjustment.
Summary by CodeRabbit