Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sync dev with master v1.5.2 #330

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Jun 6, 2024

  • Synchronized dev branch with the latest changes from master after releasing version 1.5.2

Summary by CodeRabbit

  • Bug Fixes

    • Fixed compatibility issues with the protobuf library by updating dependency versions.
  • Chores

    • Updated version constraints for the protobuf package to ensure compatibility with the latest features and fixes.

Copy link
Contributor

coderabbitai bot commented Jun 6, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates primarily focus on adjusting the protobuf dependency version across different branches to ensure compatibility and stability. The protobuf version was fixed to "<5" in version 1.4.3, updated to ">=5.26.1" in version 1.5.2, and calls to json_format.MessageToDict were adjusted for compatibility in version 1.5.1. Additionally, the pyproject.toml file was updated to reflect the new protobuf version constraint.

Changes

File Change Summary
CHANGELOG.md Fixed protobuf dependency version for different branches, updated protobuf version, and adjusted calls to json_format.MessageToDict for compatibility.
pyproject.toml Updated protobuf version constraint from * to >=5.26.1.

Poem

In the code’s garden, where bytes do grow,
A change was made, so all would know.
Protobuf's path, now clear and bright,
Compatibility shines in the digital light.
Dependencies aligned, no more a fight,
CodeRabbit hops with pure delight! 🐇✨


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 822bc90 and 9d02df2.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
  • pyproject.toml
Additional context used
LanguageTool
CHANGELOG.md

[formatting] ~19-~19: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...y version to "<5" to for the v1.4 branch, because newer versions require a code refactori...


[duplication] ~43-~43: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...ed methods ## [1.4.0] - 2024-03-11 ### Added - Added support for all queries and messages in...


[duplication] ~67-~67: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...n` message ## [1.1.0] - 2024-01-15 ### Added - Added new functions in all Market classes to ...


[duplication] ~76-~76: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...ion files ## [1.0.1] - 2024-01-08 ### Added - Added low level API components for all module...


[uncategorized] ~77-~77: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ... [1.0.1] - 2024-01-08 ### Added - Added low level API components for all modules (chain, ...


[uncategorized] ~83-~83: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ... chain, exchange and explorer using the low level API components - Marked old function si...


[duplication] ~88-~88: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...nt functions ## [1.0] - 2023-11-01 ### Added - Added logic to support use of Client Order ID...


[uncategorized] ~93-~93: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... - Remove support for sentry nodes in mainnet network. The only supported node option...


[uncategorized] ~96-~96: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_TO)
Context: ....md file to its own CHANGELOG.md file - Remove aiocron dependency. Use plain asyncio...


[uncategorized] ~206-~206: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...mples ## [0.7] * Removed references to pysha3 library (and also eip712-struct that re...

Markdownlint
CHANGELOG.md

101-101: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


104-104: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


107-107: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


110-110: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


113-113: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


116-116: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


119-119: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


122-122: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


123-123: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


126-126: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


129-129: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


132-132: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


135-135: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


136-136: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


139-139: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


140-140: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


141-141: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


142-142: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


146-146: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


149-149: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


152-152: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


155-155: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


158-158: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


159-159: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


162-162: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


163-163: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


164-164: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


165-165: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


166-166: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


167-167: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


168-168: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


169-169: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


172-172: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


175-175: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


178-178: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


181-181: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


184-184: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


187-187: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


190-190: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


193-193: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


196-196: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


199-199: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


202-202: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


203-203: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


206-206: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


207-207: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


210-210: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


213-213: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


214-214: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


215-215: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


218-218: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


221-221: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


224-224: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


227-227: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


230-230: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


233-233: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


234-234: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


237-237: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


240-240: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


243-243: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


246-246: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


249-249: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


250-250: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


253-253: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


256-256: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


259-259: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


260-260: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


261-261: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


262-262: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


265-265: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


266-266: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


269-269: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


272-272: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


275-275: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


276-276: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


279-279: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


282-282: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


285-285: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


288-288: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


291-291: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


294-294: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


297-297: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


300-300: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


301-301: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


302-302: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


305-305: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


306-306: Expected: dash; Actual: asterisk (MD004, ul-style)
Unordered list style


74-74: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


144-144: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


6-6: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


6-6: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


14-14: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


17-17: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


18-18: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


21-21: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


22-22: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


22-22: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


25-25: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


26-26: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


26-26: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


29-29: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


30-30: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


30-30: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


34-34: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


35-35: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


35-35: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


38-38: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


39-39: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


39-39: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


42-42: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


43-43: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


43-43: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


48-48: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


49-49: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


49-49: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


52-52: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


53-53: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


53-53: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


56-56: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


57-57: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


57-57: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


62-62: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


63-63: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


63-63: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


66-66: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


67-67: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


67-67: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


70-70: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


75-75: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


76-76: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


76-76: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


81-81: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


88-88: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


88-88: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


92-92: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


100-100: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


103-103: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


106-106: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


109-109: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


112-112: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


115-115: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


118-118: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


121-121: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


125-125: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


128-128: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


131-131: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


134-134: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


138-138: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


145-145: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


148-148: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


151-151: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


154-154: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


157-157: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


161-161: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


171-171: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


174-174: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


177-177: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


183-183: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


186-186: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


189-189: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


192-192: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


195-195: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


198-198: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


201-201: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


205-205: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


209-209: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


212-212: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


217-217: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


220-220: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


223-223: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


226-226: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


229-229: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


232-232: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


236-236: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


239-239: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


242-242: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


245-245: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


248-248: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


252-252: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


255-255: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


258-258: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


264-264: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


268-268: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


271-271: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


274-274: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


278-278: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


281-281: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


284-284: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


287-287: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


290-290: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


293-293: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


296-296: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


299-299: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


304-304: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


7-7: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


15-15: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


19-19: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


27-27: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


31-31: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


36-36: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


40-40: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


44-44: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


50-50: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


54-54: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


58-58: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


64-64: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


68-68: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


71-71: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


77-77: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


82-82: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


89-89: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


93-93: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


101-101: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


104-104: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


107-107: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


110-110: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


113-113: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


116-116: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


119-119: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


122-122: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


126-126: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


129-129: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


132-132: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


135-135: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


139-139: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


146-146: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


149-149: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


152-152: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


155-155: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


158-158: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


162-162: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


172-172: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


175-175: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


178-178: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


181-181: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


184-184: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


187-187: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


190-190: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


193-193: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


196-196: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


199-199: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


202-202: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


206-206: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


210-210: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


213-213: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


218-218: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


221-221: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


224-224: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


227-227: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


230-230: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


233-233: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


237-237: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


240-240: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


243-243: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


246-246: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


249-249: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


253-253: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


256-256: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


259-259: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


265-265: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


269-269: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


272-272: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


275-275: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


279-279: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


282-282: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


285-285: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


288-288: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


291-291: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


294-294: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


297-297: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


300-300: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


305-305: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


12-12: null (MD034, no-bare-urls)
Bare URL used


308-308: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

Additional comments not posted (2)
CHANGELOG.md (2)

23-23: The update to the protobuf dependency version is correctly documented.

Tools
Markdownlint

23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


24-24: The update to json_format.MessageToDict for compatibility with the new protobuf version is correctly documented.

CHANGELOG.md Show resolved Hide resolved
aarmoa and others added 2 commits June 6, 2024 17:46
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@aarmoa aarmoa merged commit 1b00ad8 into dev Jun 6, 2024
12 checks passed
@aarmoa aarmoa deleted the feat/sync_dev_with_master_v152 branch June 6, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant