Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ofac_list_url #356

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix/ofac_list_url #356

merged 1 commit into from
Nov 13, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Nov 13, 2024

  • Fixed link to official ofac.json file
  • Refreshed the local copyof the file after the update

Summary by CodeRabbit

  • New Features

    • Updated the OFAC list with 66 new Ethereum addresses and removed 7 outdated addresses.
  • Bug Fixes

    • Corrected the URL for the OFAC list to ensure accurate access to the latest data.
  • Documentation

    • Updated the changelog to reflect the new version (1.7.2) and the changes made.

Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several updates across multiple files. A new version entry for version 1.7.2 is added in the changelog, detailing corrections to the OFAC JSON file link and a refresh of its local copy. The pyinjective/ofac.json file sees the addition of 66 new Ethereum addresses and the removal of 7, with one address being replaced. The pyinjective/ofac.py file updates the URL for the OFAC list, while the pyproject.toml file reflects a version increment to 1.7.2.

Changes

File Change Summary
CHANGELOG.md Added version entry for 1.7.2; corrected OFAC JSON file link; refreshed local copy.
pyinjective/ofac.json Added 66 new Ethereum addresses; removed 7 addresses; replaced one address with another.
pyinjective/ofac.py Updated OFAC_LIST_URL to a new format for the OFAC list URL.
pyproject.toml Updated version from 1.7.1 to 1.7.2; no other changes to metadata or dependencies.

Possibly related PRs

  • Implement OFAC list address check #346: The changes in this PR involve the implementation of an OFAC list address check, which is directly related to the updates made in the main PR regarding the OFAC list and its URL.

Suggested reviewers

  • PavelInjective

Poem

🐇 In the meadow, changes bloom,
New addresses chase away the gloom.
A link refreshed, a version new,
OFAC's list, we bid adieu!
Hopping forward, bright and spry,
With each update, we reach for the sky! 🌼


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aarmoa aarmoa merged commit 0e92559 into master Nov 13, 2024
12 checks passed
@aarmoa aarmoa deleted the fix/ofac_list_url branch November 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant