Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sync dev with v1.8.0 #359

Merged
merged 5 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

All notable changes to this project will be documented in this file.

## [1.8.0] - 9999-99-99
## [1.8.0] - 2024-11-14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version numbers are inconsistent between files

The version numbers don't match across the codebase:

  • pyproject.toml: version = "1.9.0-pre"
  • CHANGELOG.md: [1.8.0]

Please ensure version numbers are aligned:

  • Either update CHANGELOG.md to reflect the pre-release version 1.9.0-pre
  • Or update pyproject.toml to match the release version 1.8.0
🔗 Analysis chain

Version number inconsistency detected.

The changelog shows version 1.8.0, but according to the AI summary, pyproject.toml has been updated to version 1.9.0-pre. This inconsistency could cause confusion about which version is being released.

Please verify and align the version numbers across:

  1. CHANGELOG.md
  2. pyproject.toml
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version numbers across files
echo "Version in pyproject.toml:"
cat pyproject.toml | grep -A1 '\[tool\.poetry\]' | grep version

echo -e "\nVersion in CHANGELOG.md:"
head -n 10 CHANGELOG.md | grep '\[.*\]'

Length of output: 259


Script:

#!/bin/bash
# Let's try a different approach to find the version in pyproject.toml
# Using rg for better pattern matching
rg "version\s*=\s*['\"].*['\"]" pyproject.toml

# Also check setup.py and setup.cfg if they exist
fd "setup\.(py|cfg)$" -x rg "version\s*=\s*['\"].*['\"]" {}

Length of output: 142

### Changed
- The markets initialization in AsyncClient has been modified to get markets information from the chain endpoints instead of the Indexer endpoints

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "injective-py"
version = "1.8.0-pre"
version = "1.9.0-pre"
description = "Injective Python SDK, with Exchange API Client"
authors = ["Injective Labs <[email protected]>"]
license = "Apache-2.0"
Expand Down
Loading