Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations #28

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Deprecations #28

merged 4 commits into from
Nov 9, 2024

Conversation

Baptouuuu
Copy link
Member

State was introduced thinking it may have some use in other Innmind abstractions. It has never been used in 3 years. Removing it in the next major will simplify the package maintenance.

Fold was introduced to have a stateless approach for reading sockets in innmind/io. This experiment turned out to be too complex. The package now favours the use of frames.

@Baptouuuu Baptouuuu self-assigned this Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (afe8ac4) to head (044461c).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #28   +/-   ##
==========================================
  Coverage      97.16%   97.16%           
  Complexity       977      977           
==========================================
  Files             64       64           
  Lines           3488     3488           
==========================================
  Hits            3389     3389           
  Misses            99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit d4cc717 into develop Nov 9, 2024
21 checks passed
@Baptouuuu Baptouuuu deleted the deprecations branch November 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant