Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

[Tournament] Allow a captain to edit his team's name and password #44

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

Teanan
Copy link
Contributor

@Teanan Teanan commented Aug 16, 2016

(part of #33)

Not sure about the button appearance & location.
capture d ecran de 2016-08-17 01-25-16

Also, should we forbid the change when the team is validated or when the tournament begins ?

@halfa
Copy link
Member

halfa commented Aug 29, 2016

IMHO the gear need a fix. The icon doesn't stand out - not like the button it should be - and the setting meaning is not that obvious.

  • For team edit: maybe a pen-like symbol right of the team name ? In a blue button frame.
  • For tournament registration: swap the gear for a button of some sort, or edit the image to stand out (in another PR?)

@halfa
Copy link
Member

halfa commented Dec 17, 2016

@Teanan the UI can be done later on, do you want to rebase and merge this one for the time being ?

@Teanan
Copy link
Contributor Author

Teanan commented Dec 17, 2016

@halfa Yep, and I'll replace the gear tonight with an "edit team" label.
But I don't know when I'll be able to deploy in prod (currently on a train...)

@Teanan Teanan merged commit d6577bf into InsaLan:develop Dec 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants