feat : add withCodes queryparameter for GET /listeCode/{id} #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBibonne
requested changes
Dec 8, 2023
| ) throws RmesException { | ||
|
|
||
| if (!withCodes){ |
There was a problem hiding this comment.
il vaut mieux créer une méthode de controller supplémentaire qui mappe les requêtes avec un paramètre withCodes plutôt que de rallonger cette méthode existante
| codesList.remove("prefLabelLg1"); | ||
| codesList.remove("prefLabelLg2"); | ||
|
|
||
| if(codesList.has(STATUT_VALIDATION)){ |
There was a problem hiding this comment.
Séquence de code dupliquée :
- dans codeLIstImpl lignes 202, 50, 227, 237, 272, 285
- dans SutrctureImpl lignes 114, 218, 260, 414
Mieux vaut factoriser dans une méthode
| @@ -258,6 +258,24 @@ public Integer getMaxpage(String notation) throws RmesException { | |||
| } | |||
| return total; | |||
| } | |||
|
|
|||
| public String getCodesListWithoutCodes(String notation) throws RmesException{ | |||
There was a problem hiding this comment.
Nouvelle méthode non couverte par un test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suite de #103