Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow arbitrary response for suggester #900

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

QRuhier
Copy link
Contributor

@QRuhier QRuhier commented Jan 10, 2025

For suggester question only outside table, add the possibility of chosing to allow an arbritrary response.

It is quite close to clarification question for code lists, but instead of adding a list ClarificationQuestion in the question, we create a single object ArbitraryResponse.

  • on a suggester question, the user only has to chose if he wants to allow arbitrary response
  • when generating collected variables (in collected variables panel), it also generates an arbitrary variable (the user can then update its name/label) => by default, the name of the variable is ${questionName}_ARBITRARY, and its label is ${questionName}_ARBITRARY label

@QRuhier QRuhier changed the title feat: allow arbitrary for suggester feat: allow arbitrary response for suggester Jan 10, 2025
@QRuhier QRuhier force-pushed the feat/allow-arbitrary-for-suggester branch from 39e02a5 to 8aaf8b8 Compare January 10, 2025 16:22
@QRuhier QRuhier force-pushed the feat/allow-arbitrary-for-suggester branch from 8aaf8b8 to 9966148 Compare January 24, 2025 16:29
@QRuhier QRuhier marked this pull request as ready for review January 28, 2025 13:42
@QRuhier
Copy link
Contributor Author

QRuhier commented Jan 28, 2025

⚠️ do not merge until Eno dev is done

@QRuhier QRuhier requested a review from chloe-renaud January 29, 2025 10:36
@QRuhier
Copy link
Contributor Author

QRuhier commented Jan 29, 2025

I forgot to update some tests after some renames, will be fixed tomorrow

@QRuhier QRuhier force-pushed the feat/allow-arbitrary-for-suggester branch from a1d041a to 67ddb7c Compare January 30, 2025 08:53
@QRuhier QRuhier force-pushed the feat/allow-arbitrary-for-suggester branch from 61658fe to b2f78f9 Compare February 13, 2025 15:20
@laurentC35 laurentC35 force-pushed the feat/allow-arbitrary-for-suggester branch from b2f78f9 to 4167539 Compare February 17, 2025 16:59
@QRuhier QRuhier merged commit f212182 into next Feb 18, 2025
10 checks passed
@QRuhier QRuhier deleted the feat/allow-arbitrary-for-suggester branch February 18, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants