-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow arbitrary response for suggester #900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39e02a5
to
8aaf8b8
Compare
8aaf8b8
to
9966148
Compare
|
chloe-renaud
requested changes
Jan 28, 2025
src/model/formToState/component-new-edit/response-format-single.jsx
Outdated
Show resolved
Hide resolved
I forgot to update some tests after some renames, will be fixed tomorrow |
a1d041a
to
67ddb7c
Compare
MailineN
approved these changes
Jan 30, 2025
chloe-renaud
approved these changes
Jan 30, 2025
61658fe
to
b2f78f9
Compare
b2f78f9
to
4167539
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For suggester question only outside table, add the possibility of chosing to allow an arbritrary response.
It is quite close to clarification question for code lists, but instead of adding a list ClarificationQuestion in the question, we create a single object ArbitraryResponse.
${questionName}_ARBITRARY
, and its label is${questionName}_ARBITRARY label