Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fr&en translations on next #934

Merged
merged 12 commits into from
Feb 18, 2025
Merged

Conversation

MailineN
Copy link
Contributor

No description provided.

@MailineN MailineN requested review from chloe-renaud, laurentC35 and QRuhier and removed request for chloe-renaud and laurentC35 February 12, 2025 16:35
@QRuhier
Copy link
Contributor

QRuhier commented Feb 13, 2025

Could you look for improving type safety ?

  • avoid to use a key that is not defined in dictionary
  • have auto-completion with defined keys when using useTranslate()

@MailineN MailineN marked this pull request as draft February 13, 2025 09:23
@chloe-renaud
Copy link
Contributor

Can we handle form errors and toast translations?

title: z.string().min(1, 'You must provide a title'),

@MailineN MailineN marked this pull request as ready for review February 13, 2025 10:34
@chloe-renaud chloe-renaud self-requested a review February 14, 2025 12:57
@MailineN MailineN requested a review from QRuhier February 17, 2025 09:17
@chloe-renaud chloe-renaud merged commit 07ae8a1 into next Feb 18, 2025
10 checks passed
@chloe-renaud chloe-renaud deleted the feat/internationalization-next branch February 18, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants