Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close OutputStream created by writeTagFile() #195

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

KengoTODA
Copy link
Contributor

Thanks for sharing this ksp compiler, it really helps our development. 🤝

I found that OutputStream instances created by writeTagFile() are not closed, so here I want to suggest a small fix.
I will create another PR to make this KSP compiler reproducible, but first please review this small PR.

@arnaudgiuliani arnaudgiuliani added this to the 2.0 milestone Dec 18, 2024
@arnaudgiuliani arnaudgiuliani self-requested a review December 18, 2024 11:08
@arnaudgiuliani arnaudgiuliani changed the base branch from main to 2.0.0 December 20, 2024 17:44
@arnaudgiuliani arnaudgiuliani added the status:checking Ticket is currently being checked label Dec 23, 2024
@arnaudgiuliani
Copy link
Member

Good catch 👍

@arnaudgiuliani arnaudgiuliani added type:improvement and removed status:checking Ticket is currently being checked labels Dec 23, 2024
@arnaudgiuliani arnaudgiuliani merged commit 78f6ec0 into InsertKoinIO:2.0.0 Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants