Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the Provided annotation for consideration for the depende… #199

Merged

Conversation

kmbisset89
Copy link

This fixes the annotation problem of having a dependency with a Provided annotation and any other dependency related annotation such as qualifier.

@kmbisset89
Copy link
Author

@arnaudgiuliani This is the fix for the issue I opened yesterday.

@arnaudgiuliani arnaudgiuliani added this to the 2.0 milestone Dec 18, 2024
@arnaudgiuliani arnaudgiuliani self-requested a review December 18, 2024 11:06
fix: Remove the Provided annotation for consideration for the dependency.
@kmbisset89 kmbisset89 force-pushed the fix/dependency-qualifier-fix branch from 35b4881 to e80db8c Compare December 18, 2024 17:18
Copy link
Member

@arnaudgiuliani arnaudgiuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me run your PR 👍

@arnaudgiuliani arnaudgiuliani changed the base branch from main to 2.0.0 December 18, 2024 17:43
@arnaudgiuliani
Copy link
Member

I've changed to 2.0 branch

@arnaudgiuliani arnaudgiuliani merged commit 39847e4 into InsertKoinIO:2.0.0 Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants