Use kotlin.time API #1697
Closed
Use kotlin.time API #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrofsn
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
I just looked the code in github code review tool. To me it's okay. But I think @arnaudgiuliani need to double check it. ;)
| @OptIn(KoinExperimentalAPI::class) | ||
| fun runScenario(index: Int): Pair<Double, Double> { | ||
| val (app, duration) = measureDurationForResult { | ||
| // @OptIn(KoinExperimentalAPI::class) |
There was a problem hiding this comment.
Suggested change
| // @OptIn(KoinExperimentalAPI::class) |
|
Bump |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin Time API is now stable, so it's time to replace the self-made time API with it.
KoinPlatformTimeToolsand other parts of "koin time API" have been marked as deprecated and hopefully they will be removed in the future, as they shouldn't have been part of the public API.