Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround ConcurrentModificationException when closeAllScopes in js #2032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

workaround ConcurrentModificationException when closeAllScopes in js #2032

wants to merge 1 commit into from

Conversation

luozejiaqun
Copy link

Fixes gh-1963

@luozejiaqun luozejiaqun force-pushed the bugfix/closeScopeConcurrentError branch from 515352f to f649e59 Compare October 25, 2024 01:29
@arnaudgiuliani
Copy link
Member

can you propose something else? it seems a bit weird here to do that 🤔

@luozejiaqun
Copy link
Author

@arnaudgiuliani just as i mentioned in #1963 , directly calling scopes.toList() on the JS platform is ineffective because it doesn't create a new list. Therefore, we need to explicitly create a separate list.

@arnaudgiuliani arnaudgiuliani added this to the 4.1 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

ScopeRegistry.closeAllScopes() causes ConcurrentModificationException for JS
2 participants
@luozejiaqun @arnaudgiuliani