-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLOQ to sampling design and add trough as exposure metric #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really nice. Good catch on the LOQ.
I'm requesting some minor changes in documentation and testing, but I would also like to discuss generalizing this to allow calculation of all concentration metrics. For example, if you were targeting a Cmax (say for tobramycin or similar drug), is there a reason this function wouldn't work for that? Can we change the name to make it more generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example case you can add that tests the LOQ censoring happens appropriately with a well designed create_sampling_design
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, with minor rewrite to ensure tests pass
Co-authored-by: Jasmine Hughes <[email protected]>
This PR does two things: