Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLOQ to sampling design and add trough as exposure metric #8

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

dominic-irx
Copy link
Contributor

This PR does two things:

  1. Add LLOQ to the user-facing create_sampling_design function so that this can be passed into collect_tdms. Tests and documentation were changed accordingly.
  2. Add troughs as a column to dose_update, as trough is another exposure metric that is commonly used. This is intended as a temporary fix until we have time to write a create_output_design function which would specify what exposure metrics to output and when.

Copy link
Collaborator

@jasmineirx jasmineirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really nice. Good catch on the LOQ.

I'm requesting some minor changes in documentation and testing, but I would also like to discuss generalizing this to allow calculation of all concentration metrics. For example, if you were targeting a Cmax (say for tobramycin or similar drug), is there a reason this function wouldn't work for that? Can we change the name to make it more generic?

R/exposure_metrics.R Outdated Show resolved Hide resolved
R/exposure_metrics.R Outdated Show resolved Hide resolved
R/exposure_metrics.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@jasmineirx jasmineirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example case you can add that tests the LOQ censoring happens appropriately with a well designed create_sampling_design?

Copy link
Collaborator

@jasmineirx jasmineirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with minor rewrite to ensure tests pass

@dominic-irx dominic-irx merged commit d9b7e72 into main Aug 19, 2024
3 checks passed
@dominic-irx dominic-irx deleted the add_trough_exposure_temporary branch August 19, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants