ENH: Test Python wrapping with both SetPoints and SetPointsByCoordinates #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SetPoints calls in two serialization tests appear unsafe, as was reported by issue InsightSoftwareConsortium#4848 "`PointSet::SetPoints(PointsVectorContainer *)` overload leads to undefined behavior". With this commit, those tests try both using SetPointsByCoordinates and using the unsafe SetPoints overload.
github-actions
bot
added
type:Enhancement
dzenanz
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointSet::SetPoints(PointsVectorContainer *)overload leads to undefined behavior #4848With this commit, those tests try both using SetPointsByCoordinates and using the unsafe SetPoints overload.
SetPointswithSetPointsByCoordinatesin wrapping tests #4889 as it is triggered by feedback from Matt McCormick (@thewtex) at BUG: ReplaceSetPointswithSetPointsByCoordinatesin wrapping tests #4889 (comment)👉 It may be helpful to ignore white-space changes, when reviewing: https://github.com/InsightSoftwareConsortium/ITK/pull/4896/files?w=1