-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: BinaryMathematicalMorphology baseline testing #219
ENH: BinaryMathematicalMorphology baseline testing #219
Conversation
src/Filtering/BinaryMathematicalMorphology/ClosingBinaryImage/Code.cxx
Outdated
Show resolved
Hide resolved
src/Filtering/BinaryMathematicalMorphology/ClosingBinaryImage/Code.cxx
Outdated
Show resolved
Hide resolved
629e353
to
de347bf
Compare
de347bf
to
d57fa4a
Compare
@mseng10 can this please be rebased on |
d57fa4a
to
c944bb3
Compare
Looking at https://open.cdash.org/test/366062497, the differences are stark. It does not seem to work properly on Windows. |
I see. I believe this may be a symptom of a bigger issue as I have started #212 and this is producing some similar results in the Windows builds (https://open.cdash.org/viewTest.php?onlyfailed&buildid=7117682). They work fine in Linux and MacOS. I will take a deeper dive into this to try and diagnose the issue. |
Rebasing on |
c944bb3
to
e739d4f
Compare
e739d4f
to
b625917
Compare
b625917 rebased on |
b051505
to
8e28b03
Compare
Either the baselines seem to need an update: Or the test images do not look good. Anyone having the time to update the necessary images? |
This bug seems to affect many more examples. A search for |
6adfec0
to
f785ae9
Compare
This enables baseline testing for the BinaryMathematicalMorphology module. This specifically does the following: - Defines OutputBaseline for all baseline tests in Filtering/BinaryMathematicalMorphology/CMakeLists.txt - Implements ITK's WriteImage function for ClosingBinaryImage, OpenBinaryImage and PruneBinaryImage. - Saves new baseline images for ClosingBinaryImage, OpenBinaryImage, and PruneBinaryIamge. - Changes original output ClosingBinaryImage.png, OpenBinaryImage.png and PruneBinaryImage.png to clarify these are outputs in the QuickView window. - Allow user to define input and output file paths for ClosingBinaryImage, OpenBinaryImage, PruneBinaryImage.
f785ae9
to
cbc92e9
Compare
Not sure why the doc build was cancelled. It seems like we cannot run just that one. The rest are passing. Edit: I'd say that the netlify deploy seems that the docs/site were correctly generated: However, it also shows that:
Not sure if best would be to leave them for a separate issue/PR. |
build-test-documentation (ubuntu-18.04): |
The input images are not the same. Pruning has an "erroneous" pixel. You are right that closing should produce rounded corners. |
I created #308 to keep track of the allocate issue. |
This enables baseline testing for the
BinaryMathematicalMorphology
module. This specifically does the following:
OutputBaseline
for all baseline tests inFiltering/BinaryMathematicalMorphology/CMakeLists.txt
ClosingBinaryImage
,OpenBinaryImage
andPruneBinaryImage
. This that takes an Image and output filename as arguments and saves the output image to the output image filename.ClosingBinaryImage
,OpenBinaryImage
, andPruneBinaryIamge
.ClosingBinaryImage.png
,OpenBinaryImage.png
andPruneBinaryImage.png
to clarify these are outputs in theQuickView
window.
ClosingBinaryImage
,OpenBinaryImage
,PruneBinaryImage
.