Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted compile fixes #170

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Assorted compile fixes #170

merged 5 commits into from
Feb 3, 2025

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jan 22, 2025

This still does not get a correct build behavior of examples outside of ITK, but these should all be steps in the right direction.

This makes gives us the ITK_DIR it was configured with.
That prevents accidental use of two different ITK versions.
This allows standalone building with less warnings
Typical error message was:

Configuring SEM CLI module: AtlasBuilderUsingIntensity
CMake Warning (dev) at C:/Misc/SlicerExecutionModel/CMake/SEMMacroBuildCLI.cmake:57 (message):
  Specified LOGO_HEADER [/docs/TubeTKLogo.h] doesn't exist
Call Stack (most recent call first):
  AtlasBuilderUsingIntensity/CMakeLists.txt:42 (SEMMacroBuildCLI)
This warning is for project developers.  Use -Wno-dev to suppress it.
@dzenanz dzenanz requested a review from aylward January 22, 2025 20:00
@dzenanz dzenanz requested a review from hjmjohnson January 31, 2025 21:11
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes seem reasonable.

@dzenanz dzenanz marked this pull request as ready for review February 3, 2025 21:34
@dzenanz dzenanz merged commit 508801a into master Feb 3, 2025
47 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants